Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract Transactions Middleware #7138

Merged
merged 16 commits into from
Jul 8, 2024
Merged

Contract Transactions Middleware #7138

merged 16 commits into from
Jul 8, 2024

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jul 3, 2024

Description

#7134

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 634.45 kB → 634.99 kB (+554 B) +0.09%
Changeset
File Δ Size
src/web3.ts 📈 +444 B (+5.39%) 8.05 kB → 8.48 kB
../web3-eth-contract/lib/commonjs/contract.js 📈 +1.01 kB (+2.33%) 43.46 kB → 44.47 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 615.15 kB → 615.69 kB (+554 B) +0.09%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

github-actions[bot]
github-actions bot reviewed Jul 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 3c63d60 Previous: 280b8f0 Ratio
processingTx 8625 ops/sec (±4.09%) 8643 ops/sec (±4.01%) 1.00
processingContractDeploy 39880 ops/sec (±6.28%) 37706 ops/sec (±7.16%) 0.95
processingContractMethodSend 15338 ops/sec (±7.96%) 15011 ops/sec (±8.43%) 0.98
processingContractMethodCall 26490 ops/sec (±8.22%) 26199 ops/sec (±7.75%) 0.99
abiEncode 41269 ops/sec (±6.92%) 40879 ops/sec (±7.43%) 0.99
abiDecode 29817 ops/sec (±6.41%) 30556 ops/sec (±6.68%) 1.02
sign 1490 ops/sec (±3.79%) 1503 ops/sec (±3.72%) 1.01
verify 367 ops/sec (±0.78%) 363 ops/sec (±0.57%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions bot requested a deployment to web3-js-docs (Preview) July 3, 2024 16:20 Abandoned
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.45%. Comparing base (280b8f0) to head (3c63d60).

Additional details and impacted files 
@@           Coverage Diff           @@
##              4.x    #7138   +/-   ##
=======================================
  Coverage   94.44%   94.45%           
=======================================
  Files         215      215           
  Lines        8366     8379   +13     
  Branches     2304     2310    +6     
=======================================
+ Hits         7901     7914   +13     
  Misses        465      465
Flag Coverage Δ
UnitTests 94.45% <93.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jdevcs jdevcs marked this pull request as ready for review July 4, 2024 13:39
@jdevcs jdevcs merged commit e9fc019 into 4.x Jul 8, 2024
53 checks passed
@jdevcs jdevcs deleted the junaid/contractstxmiddleware branch July 8, 2024 14:20
@luu-alex luu-alex mentioned this pull request Jul 10, 2024
Merged
@swirlds-automation swirlds-automation mentioned this pull request Aug 20, 2024
Merged
This was referenced Sep 12, 2024
Open
Open
Open
Open
@snyk-io snyk-io bot mentioned this pull request Sep 22, 2024
Open
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@avkos avkos avkos approved these changes

@luu-alex luu-alex Awaiting requested review from luu-alex luu-alex is a code owner

@Muhammad-Altabba Muhammad-Altabba Awaiting requested review from Muhammad-Altabba Muhammad-Altabba is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdevcs @avkos